Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 )
Change subject: IMPALA-5293: Turn insert clustering on by default ...................................................................... Patch Set 6: (4 comments) Thanks for the review, please see my inline comments and PS6. http://gerrit.cloudera.org:8080/#/c/9153/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9153/5//COMMIT_MSG@11 PS5, Line 11: to a query plan. The hint is only effective for HDFS and Kudu tables. > Why does clustered issue a warning? We change defaults all the time and use Leftover from a previous PS. :( Removed it. http://gerrit.cloudera.org:8080/#/c/9153/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/9153/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1893 PS5, Line 1893: // Test clustered hint. > Where's the expected warning? Removed in last PS. Fixed the comment. http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/insert.test File testdata/workloads/functional-planner/queries/PlannerTest/insert.test: http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/insert.test@813 PS5, Line 813: # IMPALA-6280: clustered (default) with outer join, inline view, and TupleisNullPredicate > Where did this come from? I changed it to use alltypessmall like the other tests in this file. This query is tested in QueryTest/insert.test and in one of the previous PSs, Tim pointed out that it should still have a clustering node. I added this test to make sure that it does so in the plan, too. Let me know if you'd like to remove the test. http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/with-clause.test File testdata/workloads/functional-planner/queries/PlannerTest/with-clause.test: http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/with-clause.test@550 PS5, Line 550: # sure that noclustered hint prevents addition of a sort node before writing to HDFS. > of a sort node Done -- To view, visit http://gerrit.cloudera.org:8080/9153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbf2368cf4415e6ecfa65058daf6ff87ef62f9d9 Gerrit-Change-Number: 9153 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Feb 2018 00:03:14 +0000 Gerrit-HasComments: Yes
