Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 )
Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/9292/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9292/6//COMMIT_MSG@9 PS6, Line 9: /rpcz debug web page If possible, could you post a link to a screenshot of a /rpcz page with this change? It'll be easier to review the HTML and JS part with a visual. http://gerrit.cloudera.org:8080/#/c/9292/6/be/src/rpc/impala-service-pool.h File be/src/rpc/impala-service-pool.h: http://gerrit.cloudera.org:8080/#/c/9292/6/be/src/rpc/impala-service-pool.h@36 PS6, Line 36: // RPC metrics that are shared across all service pools. They need to be passed into the : // service pool constructor and will aggregate values across all pools. : struct RpcMetrics { : // Number of RPCs that were rejected due to the queue being full. Not owned. : IntCounter* rpcs_queue_overflow = nullptr; : }; Do we need this now since we only have one service pool? My take is that we can add it as necessary, since we already have a counter to track the same thing within the ServicePool. http://gerrit.cloudera.org:8080/#/c/9292/5/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/9292/5/be/src/rpc/impala-service-pool.cc@225 PS5, Line 225: The RPC handler can run asynchronously, so we can't accurately track the num_in_handlers from here. So, it'd be better to remove this. http://gerrit.cloudera.org:8080/#/c/9292/5/be/src/rpc/impala-service-pool.cc@238 PS5, Line 238: Wouldn't microseconds be too granular for the webpages? http://gerrit.cloudera.org:8080/#/c/9292/5/be/src/rpc/impala-service-pool.cc@256 PS5, Line 256: document->GetAllocator()); : value->AddMember("incoming_que We'll have to remove this. -- To view, visit http://gerrit.cloudera.org:8080/9292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7af7c1a84a5be82c979ca4ef1edf35167493be3f Gerrit-Change-Number: 9292 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Feb 2018 23:48:15 +0000 Gerrit-HasComments: Yes
