Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 )
Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9292/5/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/9292/5/be/src/rpc/impala-service-pool.cc@225 PS5, Line 225: > Removed it. Can you clarify what asynchronously means here? Are you concern One example is that in the KrpcDataStreamRecvr, we can defer responding to RPCs for early senders. So the RPC is technically not handled until the RPC is responded to. However in this case, the 'num_in_handlers_' wouldn't reflect the number of RPCs being handled correctly. -- To view, visit http://gerrit.cloudera.org:8080/9292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7af7c1a84a5be82c979ca4ef1edf35167493be3f Gerrit-Change-Number: 9292 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Feb 2018 00:43:22 +0000 Gerrit-HasComments: Yes
