Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 )
Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/9506/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9506/6//COMMIT_MSG@10 PS6, Line 10: Update commit message http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py@1541 PS6, Line 1541: ..contains a trailing.... http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py@1541 PS6, Line 1541: Ldap nit:LDAP http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py@1542 PS6, Line 1542: echo nit: Maybe single quote 'echo' and 'echo -n' ? http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py@1539 PS6, Line 1539: if options.ldap_password_cmd.strip().startswith('echo') and \ : options.ldap_password.endswith('\n'): : print_to_stderr("Warning: Ldap password contains trailing newline. " : "Did you use echo instead of echo -n?") Should we do this only if the LDAP auth fails? Otherwise, it'd be an unnecessary warning. http://gerrit.cloudera.org:8080/#/c/9506/6/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/9506/6/shell/option_parser.py@202 PS6, Line 202: "which does not contain trailing newline.") Don't think we can dictate this and it depends on the LDAP implementation. Maybe not mention this at all? -- To view, visit http://gerrit.cloudera.org:8080/9506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie570166aea62af223905b7f0124e9efb15a88ac7 Gerrit-Change-Number: 9506 Gerrit-PatchSet: 6 Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 05:50:19 +0000 Gerrit-HasComments: Yes
