Donghui Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 )
Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly ...................................................................... Patch Set 7: (4 comments) Thanks. I've changed the code according to your opinion. http://gerrit.cloudera.org:8080/#/c/9506/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9506/6//COMMIT_MSG@10 PS6, Line 10: authentication failure, but the user can't detect the cause of the failure. > Update commit message Done http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py@1541 PS6, Line 1541: subp > nit:LDAP Done http://gerrit.cloudera.org:8080/#/c/9506/6/shell/impala_shell.py@1539 PS6, Line 1539: y: : p = subprocess.Popen(shlex.split(options.ldap_password_cmd), stdout=subprocess.PIPE, : stderr=subprocess.PIPE) : options.ldap_password, stderr = p.communicate() > Should we do this only if the LDAP auth fails? Otherwise, it'd be an unnece Done http://gerrit.cloudera.org:8080/#/c/9506/6/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/9506/6/shell/option_parser.py@202 PS6, Line 202: > Don't think we can dictate this and it depends on the LDAP implementation. Done -- To view, visit http://gerrit.cloudera.org:8080/9506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie570166aea62af223905b7f0124e9efb15a88ac7 Gerrit-Change-Number: 9506 Gerrit-PatchSet: 7 Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 07:37:58 +0000 Gerrit-HasComments: Yes
