Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 )
Change subject: IMPALA-6610: Impala shell fetches the value of ldap_password_cmd incorrectly ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/9506/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9506/8//COMMIT_MSG@7 PS8, Line 7: Impala shell fetches the value of ldap_password_cmd incorrectly Update http://gerrit.cloudera.org:8080/#/c/9506/8//COMMIT_MSG@9 PS8, Line 9: The value of LDAP password in Impala shell contains extra line break causes nit: Remove trailing spaces and wrap (here and below) http://gerrit.cloudera.org:8080/#/c/9506/8/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9506/8/shell/impala_shell.py@821 PS8, Line 821: if options.ldap_password_cmd.strip().startswith('echo') and \ Add checks for ldap_password_cmd & ldap_password not being None. Else shell can crash with an error if it hits this Exception and --ldap_password_cmd is not used. -- To view, visit http://gerrit.cloudera.org:8080/9506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie570166aea62af223905b7f0124e9efb15a88ac7 Gerrit-Change-Number: 9506 Gerrit-PatchSet: 8 Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 18:34:44 +0000 Gerrit-HasComments: Yes
