Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 )
Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 ...................................................................... Patch Set 1: > Do any of those benchmarks verify compile time performance? The query time in the attached benchmarks include the codegen compile time as well. I also tired pulling out the codegen compile time individually from the query profiles and doing a similar analysis. The delta in those varies alot along with st.dev being high too. Since the scale of those timings is in milliseconds and codegen time reported is the wall clock time, it might be difficult to seperate the noise. The variation in codegen time would be compensated by the variation in query execution time. I believe that just looking at their cumulative effect should be good enough for now. I also did some initial testing to see if codegen compile time improves for one of the queries (large num of OR-predicates) that has been a problem in the past. That time improved from ~20sec to ~14sec. -- To view, visit http://gerrit.cloudera.org:8080/9584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0a15cb53feab89e7b35a56b67b3b30eb3e62c6b Gerrit-Change-Number: 9584 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Mar 2018 01:30:39 +0000 Gerrit-HasComments: No
