Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 )
Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/9584/1/be/src/codegen/llvm-codegen.cc@292 PS1, Line 292: move(err), [&](llvm::ErrorInfoBase& eib) { err_string = eib.message(); }); > Ok, but we don't expect getOwningLazyBitcodeModule() to return something vi Nope http://gerrit.cloudera.org:8080/#/c/9584/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/9584/1/bin/bootstrap_toolchain.py@153 PS1, Line 153: toolchain_build_id = "34-9407149f5f" > Let's make sure we don't forget this :) Done -- To view, visit http://gerrit.cloudera.org:8080/9584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0a15cb53feab89e7b35a56b67b3b30eb3e62c6b Gerrit-Change-Number: 9584 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 19:10:45 +0000 Gerrit-HasComments: Yes
