Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 )
Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 ...................................................................... Patch Set 1: I don't think looking at cumulative time is quite sufficient unless we have targeted queries to benchmark it (which we might). That's because we also want to optimize for short running queries where codegen can dominate the time. We don't have to go crazy with it, but it'd be good to be assured that e.g. compile time doesn't increase significantly -- there could be new optimization passes that don't help us but take up time, for example. -- To view, visit http://gerrit.cloudera.org:8080/9584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0a15cb53feab89e7b35a56b67b3b30eb3e62c6b Gerrit-Change-Number: 9584 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Mar 2018 16:51:33 +0000 Gerrit-HasComments: No
