Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9751 )
Change subject: [experimental] Clang Tidy Diff trial balloon ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9751/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9751/1//COMMIT_MSG@22 PS1, Line 22: The main change is to find a way to get the > I agree. This is mostly a direct translation of what Kudu does, so I think I don't think I quite understand what facts about the status quo make it so that the current tidy build is not usable. The Jenkins job is basically a wrapper around bin/run_clang_tidy.sh &>"${TIDY_BUILD_OUT}" ! grep ']' "${TIDY_BUILD_OUT}" -- To view, visit http://gerrit.cloudera.org:8080/9751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb6a13400367fd3d12a4738bbb2dfc944466a7 Gerrit-Change-Number: 9751 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sun, 25 Mar 2018 01:06:11 +0000 Gerrit-HasComments: Yes
