Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9751 )
Change subject: [experimental] Clang Tidy Diff trial balloon ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9751/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9751/1//COMMIT_MSG@22 PS1, Line 22: The main change is to find a way to get the > I don't want to speak with Joe, but there are two benefits here that I see: I see - I always buildall, so I never noticed that myself. As long as the codebase remains tidy-clean, run_clang_tidy will show the diff from upstream, since upstream would produce no tidy violations. That said, I'm now understanding Joe's point that "it might let us push things in the direction we want to go without rewriting". Given how simplistic the Jenkins job is, I'd lean towards #3, #1, #2 for the ordering. -- To view, visit http://gerrit.cloudera.org:8080/9751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb6a13400367fd3d12a4738bbb2dfc944466a7 Gerrit-Change-Number: 9751 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 25 Mar 2018 20:25:53 +0000 Gerrit-HasComments: Yes
