Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9751 )
Change subject: [experimental] Clang Tidy Diff trial balloon ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9751/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9751/1//COMMIT_MSG@22 PS1, Line 22: The main change is to find a way to get the > The backstory on this (which is somewhat redundant given Phil's comment) is I like your last suggestion as an alternative to doing #3 first. Maybe it would be good to, in this patch, keep both systems but label them differently and maybe even preemptively add some more of those checks we'll eventually want but that we are not willing to apply to the whole codebase. -- To view, visit http://gerrit.cloudera.org:8080/9751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb6a13400367fd3d12a4738bbb2dfc944466a7 Gerrit-Change-Number: 9751 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Mar 2018 02:39:05 +0000 Gerrit-HasComments: Yes
