Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9800 )

Change subject: IMPALA-6724: Incorrect exception handling in create function 
statement
......................................................................


Patch Set 3:

I think our hands could be similarly tied if we don't allow built-in names. 
That limits our ability to add new built-in functions because a user may 
already have a UDF with that same name.

I agree we need to resolve your concern, Tim. My understanding is that UDFs 
that clash with a built-in must be fully-qualified. An unqualified function 
invokation should default to "_impala_builtins", and only resolve to a UDF if 
there is no match in "_impala_builtins".


--
To view, visit http://gerrit.cloudera.org:8080/9800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa
Gerrit-Change-Number: 9800
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:48:25 +0000
Gerrit-HasComments: No

Reply via email to