Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 )
Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9800/5/fe/src/main/java/org/apache/impala/analysis/FunctionName.java File fe/src/main/java/org/apache/impala/analysis/FunctionName.java: http://gerrit.cloudera.org:8080/#/c/9800/5/fe/src/main/java/org/apache/impala/analysis/FunctionName.java@104 PS5, Line 104: * set the database name to _impala_builtins. > I had the same question and the resolution seems kind of counterintuitive f Tim brought up a security concern which I think is a valid concern. As an analogy, think of it like the UNIX way of doing path resolution. ls --> from /bin/ls ./ls --> from `pwd`/ls (we need to be explicit to execute our custom ls) In other words, we should never allow users to override a built-in function. If they want to use an overloaded function, they need to be explicit. -- To view, visit http://gerrit.cloudera.org:8080/9800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa Gerrit-Change-Number: 9800 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 19:12:21 +0000 Gerrit-HasComments: Yes
