Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 )
Change subject: IMPALA-6724: Incorrect exception handling in create function statement ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9800/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9800/3//COMMIT_MSG@10 PS3, Line 10: The reason for doing this Does this statement refer to the current state or the proposed state? The current state blocks the clash via an exception. The proposed change will avoid the clash for the default database and allow "clashes" with builtin's for non-default databases. http://gerrit.cloudera.org:8080/#/c/9800/3//COMMIT_MSG@10 PS3, Line 10: . would it be more accurate to further specify: ... when the fn name is qualified (either explicitly or implicitly via "use") for a database other than the default database. -- To view, visit http://gerrit.cloudera.org:8080/9800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic30df56ac276970116715c14454a5a2477b185fa Gerrit-Change-Number: 9800 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 19:25:52 +0000 Gerrit-HasComments: Yes
