Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20850 )
Change subject: IMPALA-12533: Support row materialization outside of fetch lock ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/codegen/llvm-codegen.cc@263 PS7, Line 263: return status; Should this also call codegen->reset()? http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/fragment-state.h File be/src/runtime/fragment-state.h: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/fragment-state.h@58 PS7, Line 58: void GetCodegenRef(std::shared_ptr<LlvmCodeGen>& codegen); nit: this makes more sense to me as SetCodegenRef. And most idiomatic version would take std::shared_ptr<LlvmCodeGen> by value and std::move to codegen_. http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h File be/src/service/query-result-set.h: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h@98 PS7, Line 98: std::shared_ptr<LlvmCodeGen>& GetCodegenPtr() { return codegen; } Safer to return a const&. Don't want a caller to be able to reset it to delete the codegen early. http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h@109 PS7, Line 109: std::shared_ptr<LlvmCodeGen> codegen; I don't see this set anywhere. -- To view, visit http://gerrit.cloudera.org:8080/20850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9512aa6022dbcf81e7eb5f559853b89fe80bd23 Gerrit-Change-Number: 20850 Gerrit-PatchSet: 7 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 23:30:38 +0000 Gerrit-HasComments: Yes
