Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20850 )
Change subject: IMPALA-12533: Support row materialization outside of fetch lock ...................................................................... Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/codegen/llvm-codegen.cc@263 PS7, Line 263: return status; > Should this also call codegen->reset()? Done http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/coordinator.cc@1050 PS7, Line 1050: coord_instance_->GetCodegenRef(results->GetCodegenPtr()); > Oh, I think I understand this now. It's assigning the codegen object held b Changed as suggested. http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/fragment-state.h File be/src/runtime/fragment-state.h: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/fragment-state.h@58 PS7, Line 58: void GetCodegenRef(std::shared_ptr<LlvmCodeGen>& codegen); > nit: this makes more sense to me as SetCodegenRef. And most idiomatic versi Changed to SetCodegenRef. I want to preserve the existing references. http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-options.h@53 PS1, Line 53: TImpalaQueryOptions::DELAY_MATERIALIZE_RESULTS_THRESHOLD + 1); \ > line too long (108 > 90) Done http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h File be/src/service/query-result-set.h: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h@98 PS7, Line 98: std::shared_ptr<LlvmCodeGen>& GetCodegenPtr() { return codegen; } > Safer to return a const&. Don't want a caller to be able to reset it to del This is set externally and needs to be non-const. http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h@109 PS7, Line 109: std::shared_ptr<LlvmCodeGen> codegen; > I don't see this set anywhere. It is set externally as a reference. http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc File be/src/service/query-result-set.cc: http://gerrit.cloudera.org:8080/#/c/20850/1/be/src/service/query-result-set.cc@190 PS1, Line 190: /// Add a row from a TResultRow > Functions and variables have blank lines around them, and comments describi Done http://gerrit.cloudera.org:8080/#/c/20850/3/be/src/service/query-result-set.cc File be/src/service/query-result-set.cc: http://gerrit.cloudera.org:8080/#/c/20850/3/be/src/service/query-result-set.cc@168 PS3, Line 168: > This should be moved to the 'private' block below. Done http://gerrit.cloudera.org:8080/#/c/20850/5/be/src/service/query-result-set.cc File be/src/service/query-result-set.cc: http://gerrit.cloudera.org:8080/#/c/20850/5/be/src/service/query-result-set.cc@107 PS5, Line 107: /// Handle to shared runtime state. This is reentrant > nit: Trailing slash. Done -- To view, visit http://gerrit.cloudera.org:8080/20850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9512aa6022dbcf81e7eb5f559853b89fe80bd23 Gerrit-Change-Number: 20850 Gerrit-PatchSet: 7 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Sat, 27 Jan 2024 01:29:29 +0000 Gerrit-HasComments: Yes
