Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20850 )
Change subject: IMPALA-12533: Support row materialization outside of fetch lock ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/coordinator.cc@1050 PS7, Line 1050: coord_instance_->GetCodegenRef(results->GetCodegenPtr()); Oh, I think I understand this now. It's assigning the codegen object held by FragmentInstance (via FragmentInstanceState aka coord_instance_) to the QueryResultSet results (via a ref GetCodegenPtr). That's completed inverted from what I'd expect. Why doesn't QueryResultSet have a SetCodegenRef, and the others GetCodegenRef that returns a shared_ptr<LlvmCodeGen>? -- To view, visit http://gerrit.cloudera.org:8080/20850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9512aa6022dbcf81e7eb5f559853b89fe80bd23 Gerrit-Change-Number: 20850 Gerrit-PatchSet: 7 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Jan 2024 23:37:27 +0000 Gerrit-HasComments: Yes