Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21187 )
Change subject: IMPALA-12928: Mask JDBC table property dbcp.password for DESC FORMATTED and SHOW CREATE TABLE ...................................................................... Patch Set 2: Code-Review+1 (1 comment) I just have 1 question. http://gerrit.cloudera.org:8080/#/c/21187/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21187/2//COMMIT_MSG@17 PS2, Line 17: - Added end-to-end test cases. : - Passed core tests. Should we add test that "dbcp.password" never logged as well? See tests/verifiers/test_banned_log_messages.py. -- To view, visit http://gerrit.cloudera.org:8080/21187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83dc32c8d0fec1cdfdfe06e720561b2ae1adf5df Gerrit-Change-Number: 21187 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2024 20:31:32 +0000 Gerrit-HasComments: Yes
