gaurav singh has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21187 )

Change subject: IMPALA-12928: Mask JDBC table property dbcp.password for DESC 
FORMATTED and SHOW CREATE TABLE
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21187/2/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java:

http://gerrit.cloudera.org:8080/#/c/21187/2/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@479
PS2, Line 479:           properties.put(key, "******");
Should the number of astreix(s) be equal to the length of the password instead 
of fixed size ?



--
To view, visit http://gerrit.cloudera.org:8080/21187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83dc32c8d0fec1cdfdfe06e720561b2ae1adf5df
Gerrit-Change-Number: 21187
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>
Gerrit-Comment-Date: Mon, 25 Mar 2024 21:04:58 +0000
Gerrit-HasComments: Yes

Reply via email to