Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21187 )
Change subject: IMPALA-12928: Mask JDBC table property dbcp.password for DESC FORMATTED and SHOW CREATE TABLE ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21187/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21187/2//COMMIT_MSG@17 PS2, Line 17: - Added end-to-end test cases. : - Passed core tests. > Table parameters seems to be logged at hive-metastore.log. This might need There is generic tool in productions to prevent sensitive info in the log file. User could define their regular expressions to detect and redact sensitive information within SQL statement text, for example, creating a rule-file in json format and set "redaction_rules_file" point to the rule-file. See https://impala.apache.org/docs/build/html/topics/impala_logging.html. http://gerrit.cloudera.org:8080/#/c/21187/2/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/21187/2/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@479 PS2, Line 479: properties.put(key, "******"); > I think it is better this way. Equal length will make it easier to guess pa I prefer to use fixed number of astreix? -- To view, visit http://gerrit.cloudera.org:8080/21187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83dc32c8d0fec1cdfdfe06e720561b2ae1adf5df Gerrit-Change-Number: 21187 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2024 22:21:29 +0000 Gerrit-HasComments: Yes
