Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21203 )
Change subject: IMPALA-12426: Switches the duration fields to be stored in decimal seconds. ...................................................................... Patch Set 2: (3 comments) Quick comments http://gerrit.cloudera.org:8080/#/c/21203/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21203/2//COMMIT_MSG@24 PS2, Line 24: I think there should be some notes and maybe warnings saying that the query history table needs to be dropped and recreated. What would happen if you didn't do this? http://gerrit.cloudera.org:8080/#/c/21203/2/tests/util/assert_time.py File tests/util/assert_time.py: http://gerrit.cloudera.org:8080/#/c/21203/2/tests/util/assert_time.py@19 PS2, Line 19: nanoseconds Does this need to change? http://gerrit.cloudera.org:8080/#/c/21203/2/tests/util/assert_time.py@32 PS2, Line 32: float nit: a float -- To view, visit http://gerrit.cloudera.org:8080/21203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I842951a132b7b8eadccb09a3674f4c34ac42ff1b Gerrit-Change-Number: 21203 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Mar 2024 17:03:16 +0000 Gerrit-HasComments: Yes
