Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21203 )
Change subject: IMPALA-12426: Switches the duration fields to be stored in decimal seconds. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21203/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21203/2//COMMIT_MSG@17 PS2, Line 17: The prettyprint_duration function would have required a : large investment of time to make it work with decimal : values, and since the new format is more human readable : anyways, this function has been removed. I suggest to do the removal later in separate patch. The reason is that, it was originally introduced as its own commit. IMPALA-12824: Adds built-in functions prettyprint_duration and prettyprint_bytes. In case backport is needed somewhere, we can backport just IMPALA-12824 and the removal commit. http://gerrit.cloudera.org:8080/#/c/21203/2/be/src/service/workload-management-fields.cc File be/src/service/workload-management-fields.cc: http://gerrit.cloudera.org:8080/#/c/21203/2/be/src/service/workload-management-fields.cc@61 PS2, Line 61: static constexpr int8_t SECONDS_DECIMAL_PRECISION = 18; : static constexpr int8_t SECONDS_DECIMAL_SCALE = 3; : static const string SECONDS_DECIMAL_TYPE = StrCat("DECIMAL(",SECONDS_DECIMAL_PRECISION, : ",", SECONDS_DECIMAL_SCALE, ")"); Suggest to lower this to DECIMAL(9,3). I wish it still have microsecond precision if possible either by storing as: second in DECIMAL(18.6), or millisecond in DECIMAL(18,3). But don't mind with second in DECIMAL(9,3) as well. -- To view, visit http://gerrit.cloudera.org:8080/21203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I842951a132b7b8eadccb09a3674f4c34ac42ff1b Gerrit-Change-Number: 21203 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Mar 2024 19:11:41 +0000 Gerrit-HasComments: Yes
