Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21203 )
Change subject: IMPALA-12426: Switches the duration fields to be stored in decimal seconds. ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/21203/5/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/21203/5/tests/custom_cluster/test_query_live.py@318 PS5, Line 318: actual_hosts = re.search(r'Per Host Number of Fragment Instances:' : r'\s+(.*?:\d+\(\d\))\s+(.*?:\d+\(\d\))\s+(.*?:\d+\(\d\))', profile) it might be good to convert actual_hosts to list of int and then sort them, in case backend address in unsorted or fragment assignment shift. See similar method in TestExecutorGroup.__verify_fs_writers() and TestInsertHdfsWriterLimit.__run_insert_and_verify_instances(). http://gerrit.cloudera.org:8080/#/c/21203/5/tests/util/assert_time.py File tests/util/assert_time.py: http://gerrit.cloudera.org:8080/#/c/21203/5/tests/util/assert_time.py@34 PS5, Line 34: # units = {'h': 3600 * 1e9, 'm': 60 * 1e9, 's': 1e9, 'ms': 1e6, 'us': 1e3, 'ns': 1} : # units = {'h': 3600, 'm': 60, 's': 1, 'ms': 1e-3, 'us': 1e-6, 'ns': 1e-9} Remove commented lines? -- To view, visit http://gerrit.cloudera.org:8080/21203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I842951a132b7b8eadccb09a3674f4c34ac42ff1b Gerrit-Change-Number: 21203 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 20:25:45 +0000 Gerrit-HasComments: Yes
