Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21340 )

Change subject: IMPALA-13024: Ignore slots if using default pool and empty group
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21340/3/be/src/scheduling/admission-controller-test.cc
File be/src/scheduling/admission-controller-test.cc:

http://gerrit.cloudera.org:8080/#/c/21340/3/be/src/scheduling/admission-controller-test.cc@605
PS3, Line 605:   // Create ScheduleStates to run on QUEUE_D on 12 hosts.
             :   // Running in both default and non-default executor groups is 
simulated.
Drop this comment. Leftover from copy-paste.


http://gerrit.cloudera.org:8080/#/c/21340/3/be/src/scheduling/admission-controller-test.cc@629
PS3, Line 629: Schedule should all be admitted.
"All schedules should be admitted".



--
To view, visit http://gerrit.cloudera.org:8080/21340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b08dea7ba0c78ac6b98c7a0b148df8fb036c4d0
Gerrit-Change-Number: 21340
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2024 16:52:34 +0000
Gerrit-HasComments: Yes

Reply via email to