Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21340 )
Change subject: IMPALA-13024: Ignore slots if using default pool and empty group ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21340/3/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/21340/3/be/src/scheduling/admission-controller-test.cc@605 PS3, Line 605: // Create ScheduleStates to run on "default-pool" on 12 hosts. : // Running both distributed and coordinator-only schedule. > Drop this comment. Leftover from copy-paste. Done http://gerrit.cloudera.org:8080/#/c/21340/3/be/src/scheduling/admission-controller-test.cc@629 PS3, Line 629: ERT_TRUE(admission_controller->C > "All schedules should be admitted". Done -- To view, visit http://gerrit.cloudera.org:8080/21340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b08dea7ba0c78ac6b98c7a0b148df8fb036c4d0 Gerrit-Change-Number: 21340 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Apr 2024 18:36:39 +0000 Gerrit-HasComments: Yes