Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 )
Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc@373 PS2, Line 373: mem_for_64_entries Looks like the 64 is the sampling number, can we give the 64 a const, and rename the mem_for_64_entries to mem_for_sampling_entries? http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc@378 PS2, Line 378: if (capacity_ > 1) Should "if (capacity_ > 0)" also hold the DCHECK? Or is it possible that the mem_usage can exceed the MAX_EXPR_VALUES_CACHE_BYTES in that case? Maybe we can log something if mem_usage can exceed MAX_EXPR_VALUES_CACHE_BYTES and the case is rare -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sat, 25 May 2024 16:53:42 +0000 Gerrit-HasComments: Yes