Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 )
Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc@373 PS2, Line 373: rocessor dependent > Ack. Maybe also adds this to the code comment to explain why 64 is picked? Done http://gerrit.cloudera.org:8080/#/c/21455/4/testdata/workloads/tpcds_partitioned/queries File testdata/workloads/tpcds_partitioned/queries: http://gerrit.cloudera.org:8080/#/c/21455/4/testdata/workloads/tpcds_partitioned/queries@1 PS4, Line 1: ../tpcds/queries > I don't quite understand the difference between using testdata/workloads/tp get_workload() along with table format dimension dictate which database the query will run. For example, tpcds_partitioned + 'parquet/snap/block' = tpcds_partitioned_parquet_snap database. tpcds + 'parquet/none' = tpcds_parquet database. My intention is to run the same TPC-DS Q97 that exist in tpcds workload dir to query tpcds_partitioned_parquet_snap instead of tpcds_parquet, because all facts table in tpcds_partitioned_parquet_snap are all partitioned. In tpcds_parquet, only store_sales are partitioned. All test files under testdata/workloads/tpcds/queries/ should be compatible against tpcds_partitioned_parquet_snap. So I just create symlink instead copying all test files into separate testdata/workloads/tpcds_partitioned/queries/. Eventually, tpcds dataset should be changed to follow schema from tpcds_partitioned and we can keep just one of them. -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 31 May 2024 19:30:52 +0000 Gerrit-HasComments: Yes
