Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21455 )
Change subject: IMPALA-13075: Cap memory usage for ExprValuesCache at 256KB ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc@373 PS2, Line 373: t int sample_size > Done. Keeping it local for this Init method. Ack. Maybe also adds this to the code comment to explain why 64 is picked? http://gerrit.cloudera.org:8080/#/c/21455/2/be/src/exec/hash-table.cc@378 PS2, Line 378: // TODO: Add 'mem_ > capacity_ is capped to 1 at minimum. It is unlikely, but we want to know if Done http://gerrit.cloudera.org:8080/#/c/21455/4/testdata/workloads/tpcds_partitioned/queries File testdata/workloads/tpcds_partitioned/queries: http://gerrit.cloudera.org:8080/#/c/21455/4/testdata/workloads/tpcds_partitioned/queries@1 PS4, Line 1: ../tpcds/queries I don't quite understand the difference between using testdata/workloads/tpcds/queries and the new workload tpcds_partitioned in test_join_queries.py. Is there a specific reason why test_join_queries.py uses tpcds_partitioned, which seems to be same to tpcds? -- To view, visit http://gerrit.cloudera.org:8080/21455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee27cbbe8d3100301d05a6516b62c45975a8d0e0 Gerrit-Change-Number: 21455 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 31 May 2024 18:57:48 +0000 Gerrit-HasComments: Yes
