Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22018 )
Change subject: IMPALA-13510: Unset the environment variable for tuple cache tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22018/1/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/22018/1/tests/custom_cluster/test_tuple_cache.py@108 PS1, Line 108: os.unsetenv("TUPLE_CACHE_DIR") I think this has the effect of unsetting it for any custom cluster tests that run after. That seems a little messy, and may prevent those tests from using the tuple cache though. We should restore the setting in a teardown_class method. -- To view, visit http://gerrit.cloudera.org:8080/22018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b551e533c7c69d5b29ed6ad6af90be57f53c937 Gerrit-Change-Number: 22018 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 23:11:16 +0000 Gerrit-HasComments: Yes
