Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22018 )

Change subject: IMPALA-13510: Unset the environment variable for tuple cache 
tests
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22018/1/tests/custom_cluster/test_tuple_cache.py
File tests/custom_cluster/test_tuple_cache.py:

http://gerrit.cloudera.org:8080/#/c/22018/1/tests/custom_cluster/test_tuple_cache.py@108
PS1, Line 108:     os.unsetenv("TUPLE_CACHE_DIR")
> I think this has the effect of unsetting it for any custom cluster tests th
I tested to add a second class TestTupleCache1 after test class TestTupleCache, 
and one unset, one without unsetting the variable, and the first passed but the 
second test class without unsetting failed. This seems to tell the unset 
operation only affects the environment within this test class. But, I will add 
teardown_class to ensure it.



--
To view, visit http://gerrit.cloudera.org:8080/22018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b551e533c7c69d5b29ed6ad6af90be57f53c937
Gerrit-Change-Number: 22018
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 05 Nov 2024 01:47:49 +0000
Gerrit-HasComments: Yes

Reply via email to