Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22018 )
Change subject: IMPALA-13510: Unset the environment variable for tuple cache tests ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22018/2/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/22018/2/tests/custom_cluster/test_tuple_cache.py@109 PS2, Line 109: if cls.org_tuple_cache_dir is not None: > nit: you could pull this out of the conditional and eliminate the else bran Done -- To view, visit http://gerrit.cloudera.org:8080/22018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b551e533c7c69d5b29ed6ad6af90be57f53c937 Gerrit-Change-Number: 22018 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2024 20:09:16 +0000 Gerrit-HasComments: Yes
