Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: WIP IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 10: (10 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/rpc/authentication.cc@229 PS10, Line 229: // The last segment of a OAuth is the signature, which is used to verify that the token was line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/rpc/authentication.cc@262 PS10, Line 262: // OAuth is only secure when used with TLS. But in some deployment scenarios, TLS is handled line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util-internal.h File be/src/util/oauth-util-internal.h: http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util-internal.h@246 PS10, Line 246: /// and updates it atomically when the public keys in OAuth are changed. Clients can obtain line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util-internal.h@255 PS10, Line 255: typedef std::unordered_map<std::string, std::unique_ptr<OAuthPublicKey>> OAuthPublicKeyMap; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util.h File be/src/util/oauth-util.h: http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util.h@35 PS10, Line 35: /// This class works as wrapper for oauth-cpp. It provides APIs to decode/verify OAuth token, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util.cc File be/src/util/oauth-util.cc: http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util.cc@621 PS10, Line 621: Substitute("Could not open JWKS file '$0'; $1", oauth_file_path, strerror(errno))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util.cc@862 PS10, Line 862: Status OAuthHelper::Init(const std::string& oauth_uri, bool oauth_verify_server_certificate, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/be/src/util/oauth-util.cc@877 PS10, Line 877: Status OAuthHelper::Decode(const string& token, UniqueOAuthDecodedToken& decoded_token_out) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21728/10/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/21728/10/shell/impala_shell.py@656 PS10, Line 656: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/21728/10/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/21728/10/shell/option_parser.py@237 PS10, Line 237: " flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 10 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2024 21:59:18 +0000 Gerrit-HasComments: Yes
