Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: WIP IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 11: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21728/11/be/src/util/oauth-util.cc File be/src/util/oauth-util.cc: http://gerrit.cloudera.org:8080/#/c/21728/11/be/src/util/oauth-util.cc@863 PS11, Line 863: Status OAuthHelper::Init(const std::string& oauth_uri, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21728/11/be/src/util/oauth-util.cc@864 PS11, Line 864: bool oauth_verify_server_certificate, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21728/11/be/src/util/oauth-util.cc@879 PS11, Line 879: Status OAuthHelper::Decode(const string& token, UniqueOAuthDecodedToken& decoded_token_out) { line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 11 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2024 18:24:27 +0000 Gerrit-HasComments: Yes
