Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: WIP IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 14: (22 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc File be/src/util/oauth-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@530 PS14, Line 530: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@591 PS14, Line 591: Substitute(oauth_rsa_file_format, "", "RS256", rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@639 PS14, Line 639: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@679 PS14, Line 679: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@719 PS14, Line 719: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@735 PS14, Line 735: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@773 PS14, Line 773: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@789 PS14, Line 789: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS384", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@811 PS14, Line 811: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@849 PS14, Line 849: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@887 PS14, Line 887: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@925 PS14, Line 925: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@963 PS14, Line 963: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1008 PS14, Line 1008: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1045 PS14, Line 1045: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1082 PS14, Line 1082: // Verify the OAuth token with our wrapper class which use public key retrieved from JWKS, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1118 PS14, Line 1118: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1147 PS14, Line 1147: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1175 PS14, Line 1175: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1196 PS14, Line 1196: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1216 PS14, Line 1216: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/14/be/src/util/oauth-util-test.cc@1238 PS14, Line 1238: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 14 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2024 22:15:00 +0000 Gerrit-HasComments: Yes
