Pranav Lodha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22134 )

Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables
......................................................................


Patch Set 11:

(3 comments)

> Uploaded patch set 11.

http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py
File tests/custom_cluster/test_ext_data_sources.py:

http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py@302
PS10, Line 302: i
> flake8: E265 block comment should start with '# '
Done


http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py@371
PS10, Line 371:         "hive.sql.dbcp.password.keystore" =
> line has trailing whitespace
Done


http://gerrit.cloudera.org:8080/#/c/22134/10/tests/custom_cluster/test_ext_data_sources.py@371
PS10, Line 371:
> flake8: W291 trailing whitespace
Done



--
To view, visit http://gerrit.cloudera.org:8080/22134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458
Gerrit-Change-Number: 22134
Gerrit-PatchSet: 11
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Fri, 07 Feb 2025 09:17:36 +0000
Gerrit-HasComments: Yes

Reply via email to