Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/22134/14/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java: http://gerrit.cloudera.org:8080/#/c/22134/14/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@107 PS14, Line 107: if (Strings.isNullOrEmpty(driverUrl)) { nit: there's a lot of duplication in the if and else blocks, but I also get why it's a bit tricky to clean up. Personally I'd spend some time trying to, but not going to hold up the review on it. -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 14 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 19:35:39 +0000 Gerrit-HasComments: Yes
