Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 15: (4 comments) > Uploaded patch set 15. http://gerrit.cloudera.org:8080/#/c/22134/14/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java: http://gerrit.cloudera.org:8080/#/c/22134/14/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@107 PS14, Line 107: try { > nit: there's a lot of duplication in the if and else blocks, but I also get Ack http://gerrit.cloudera.org:8080/#/c/22134/14/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@115 PS14, Line 115: dbcpDs.setDriverClassLoader(driverLoader); > It's not polite to drop the original Exception, you can add it as an additi Done http://gerrit.cloudera.org:8080/#/c/22134/14/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@135 PS14, Line 135: Entry entry = null; > Let's chain this Exception too. Done http://gerrit.cloudera.org:8080/#/c/22134/14/testdata/bin/setup-mysql-env.sh File testdata/bin/setup-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/22134/14/testdata/bin/setup-mysql-env.sh@157 PS14, Line 157: double_col DOUBLE, > nit: whitespace in "DOUBLE ," Done -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 15 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2025 19:22:03 +0000 Gerrit-HasComments: Yes
