Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22468 )
Change subject: IMPALA-13729: Accept error messages not starting with prompt ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22468/2/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/22468/2/tests/common/test_result_verifier.py@a853 PS2, Line 853: I think this assertion that expected_msg exist is exactly right after 'Query {} failed:\n' is important. For example, https://github.com/apache/impala/blob/master/tests/hs2/hs2_test_suite.py#L151-L152. expected_msg is expected at prefix. Not suffix, not somewhere in the middle. -- To view, visit http://gerrit.cloudera.org:8080/22468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac3e68bcc36776f7fd6cc9c838dd8da9c3ecf58b Gerrit-Change-Number: 22468 Gerrit-PatchSet: 2 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2025 17:07:36 +0000 Gerrit-HasComments: Yes
