Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22468 )
Change subject: IMPALA-13729: Accept error messages not starting with prompt ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22468/2/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/22468/2/tests/common/test_result_verifier.py@a853 PS2, Line 853: > Thanks! Changed. Done http://gerrit.cloudera.org:8080/#/c/22468/2/tests/common/test_result_verifier.py@826 PS2, Line 826: query_id=None > For example, tests in tests/query_test/test_kill_query.py . Ack http://gerrit.cloudera.org:8080/#/c/22468/4/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/22468/4/tests/common/test_result_verifier.py@847 PS4, Line 847: expected_msg Should it be like this? expected_position = start + len(ERROR_PROMPT) return actual_msg.find(expected_msg, expected_position) == expected_position L853 should also consider the length of m.group(1) (if you capture the whole ERROR_PROMPT). -- To view, visit http://gerrit.cloudera.org:8080/22468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac3e68bcc36776f7fd6cc9c838dd8da9c3ecf58b Gerrit-Change-Number: 22468 Gerrit-PatchSet: 4 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 16:01:09 +0000 Gerrit-HasComments: Yes
