Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22468 )

Change subject: IMPALA-13729: Accept error messages not starting with prompt
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22468/2/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

http://gerrit.cloudera.org:8080/#/c/22468/2/tests/common/test_result_verifier.py@833
PS2, Line 833: query_id
> Thanks! Which line was the comment at?
I meant this comment:
```
For `query_id`,
      - If a query id is specified in the parameter, it checks if the actual 
error
        message contains exactly the query id.
      - Otherwise, it checks whether `query_id` match the format using a
        regular expresssion.
```



--
To view, visit http://gerrit.cloudera.org:8080/22468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3e68bcc36776f7fd6cc9c838dd8da9c3ecf58b
Gerrit-Change-Number: 22468
Gerrit-PatchSet: 4
Gerrit-Owner: Xuebin Su <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Wed, 19 Feb 2025 10:43:16 +0000
Gerrit-HasComments: Yes

Reply via email to