Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22500 )
Change subject: IMPALA-13768: Redundant Iceberg delete records are shuffled around which cause error "Invalid file path arrived at builder" ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc@1182 PS1, Line 1182: filename_value_ss.ptr Unrelated: could this be NULL? We could add a DCHECK for it. http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc@1208 PS1, Line 1208: DCHECK Is it statically possible for this DCHECK to fire? Can we reach here without crossing L1190? I'm ok with it if it's for documentation, just wanted to understand. -- To view, visit http://gerrit.cloudera.org:8080/22500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695c919c9a74edec768e413a02b2ef7dbfa0d6a5 Gerrit-Change-Number: 22500 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 13:48:38 +0000 Gerrit-HasComments: Yes
