Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22500 )
Change subject: IMPALA-13768: Redundant Iceberg delete records are shuffled around which cause error "Invalid file path arrived at builder" ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22500/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22500/1//COMMIT_MSG@13 PS1, Line 13: It is not true when any of the following happens: > Can you clarify whether all three need to apply for the bug to appear or on Rephrased a bit. http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc@1182 PS1, Line 1182: filename_value_ss.ptr > Unrelated: could this be NULL? We could add a DCHECK for it. I think this could be NULL in invalid delete delta files, so I don't think we want to DCHECK this. http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc@1208 PS1, Line 1208: DCHECK > Is it statically possible for this DCHECK to fire? Can we reach here withou No, currently it should never fire. But I prefer to have it here as someone might refactor the code and move lines around. -- To view, visit http://gerrit.cloudera.org:8080/22500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695c919c9a74edec768e413a02b2ef7dbfa0d6a5 Gerrit-Change-Number: 22500 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 17:49:28 +0000 Gerrit-HasComments: Yes
