Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22500 )
Change subject: IMPALA-13768: Redundant Iceberg delete records are shuffled around which cause error "Invalid file path arrived at builder" ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/22500/1/be/src/runtime/krpc-data-stream-sender.cc@1182 PS1, Line 1182: filename_value_ss.ptr > I think this could be NULL in invalid delete delta files, so I don't think Then if the first filename is such, we won't log it like on L1201, which may not be a big problem. Anyway, this is unrelated to this change. -- To view, visit http://gerrit.cloudera.org:8080/22500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695c919c9a74edec768e413a02b2ef7dbfa0d6a5 Gerrit-Change-Number: 22500 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 18:07:26 +0000 Gerrit-HasComments: Yes
