Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/22134/14/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/22134/14/fe/pom.xml@317 PS14, Line 317: </dependency> > Why is this marked optional? Done http://gerrit.cloudera.org:8080/#/c/22134/15/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java: http://gerrit.cloudera.org:8080/#/c/22134/15/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DataSourceObjectCache.java@125 PS15, Line 125: "Unexpected error while creating datasource.", e); I don't think this is quite unexpected. copyFileFromUriToLocal can throw IOException, and I think URLClassLoader may also throw some exceptions. I think handling each exception type with a relevant message makes sense. -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 15 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Feb 2025 19:43:04 +0000 Gerrit-HasComments: Yes
