Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22577 )
Change subject: IMPALA-13822: Add more detail in impala_connection.py logs ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py@178 PS1, Line 178: must not empty Nit: "must not be empty". http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py@310 PS1, Line 310: { Is it intentional that we removed the comment mark ("--") from the beginning? I'm not familiar with these logs, but the comment at L103 suggests to me that these should be commented out. Also L314, L502. http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py@684 PS1, Line 684: {5} We could add some description before the SQL, something like "executing against ... {4}\nStatements:{5}" -- To view, visit http://gerrit.cloudera.org:8080/22577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44ea7fbec15684ac5379703f781a400b4f17da8d Gerrit-Change-Number: 22577 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:05:01 +0000 Gerrit-HasComments: Yes
