Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22577 )
Change subject: IMPALA-13822: Add more detail in impala_connection.py logs ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py@402 PS1, Line 402: log_lines maybe pass log_lines to log_client() and move the if block there? this would allow avoiding the duplication of the if block http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py@408 PS1, Line 408: t "if log_lines" seems clearer to me, as this checks for None mainly http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py@411 PS1, Line 411: n\n isn't one \n enough? -- To view, visit http://gerrit.cloudera.org:8080/22577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44ea7fbec15684ac5379703f781a400b4f17da8d Gerrit-Change-Number: 22577 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:05:59 +0000 Gerrit-HasComments: Yes
