Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22577 )
Change subject: IMPALA-13822: Add more detail in impala_connection.py logs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22577/1/tests/common/impala_connection.py@684 PS1, Line 684: {5} > I don't think it adds value. Currently, it already look long like this: The original commit (https://github.com/apache/impala/commit/6afea60) intent to have any log lines not prefixed with '--' to be a valid SQL. -- To view, visit http://gerrit.cloudera.org:8080/22577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44ea7fbec15684ac5379703f781a400b4f17da8d Gerrit-Change-Number: 22577 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:59:40 +0000 Gerrit-HasComments: Yes
