Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22613
Change subject: IMPALA-13844: Support usage of strings directly in rapidjson ...................................................................... IMPALA-13844: Support usage of strings directly in rapidjson The RapidJSON library recalculates length of a StringRef each time when using char*, until null character. Within the codebase, many times we convert from string to char* for RapidJSON. Instead with RAPIDJSON_HAS_STDSTRING, we can use strings directly, which inherently contain the size, instead of recalculating each time. This is a major convenience and a bit more efficient during both JSON generation and parsing. This simplifies many methods(i.e. AddMember, HasMember, etc) and the creation of Document::Value. This does not remove compatibility for existing char* and still remains as a stable feature within RapidJSON. Change-Id: I84c6f17690f7a2e958a6dfbb3637832f5ab6ee53 --- M be/CMakeLists.txt M be/src/catalog/catalog-server.cc M be/src/exprs/string-functions.cc M be/src/runtime/coordinator-backend-state.cc M be/src/service/impala-http-handler.cc M be/src/util/json-util.cc M be/src/util/json-util.h M be/src/util/jwt-util.cc M be/src/util/lineage-util.h M be/src/util/logging-support.cc M be/src/util/metrics.cc M be/src/util/redactor.cc M be/src/util/runtime-profile.cc M be/src/util/webserver.cc 14 files changed, 192 insertions(+), 198 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/22613/1 -- To view, visit http://gerrit.cloudera.org:8080/22613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I84c6f17690f7a2e958a6dfbb3637832f5ab6ee53 Gerrit-Change-Number: 22613 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]>
