Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22613 )
Change subject: IMPALA-13844: Support usage of strings directly in rapidjson ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22613/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/22613/1/be/CMakeLists.txt@68 PS1, Line 68: # Support using strings directly in rapidjson : SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DRAPIDJSON_HAS_STDSTRING=1") As the library was being used widely, I had set it here. Please do let me know, if I should set it somewhere else. -- To view, visit http://gerrit.cloudera.org:8080/22613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c6f17690f7a2e958a6dfbb3637832f5ab6ee53 Gerrit-Change-Number: 22613 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 11 Mar 2025 22:22:47 +0000 Gerrit-HasComments: Yes
